Closed eps1lon closed 1 year ago
codesandbox-ci[bot]
commented
1 year ago This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 746def61471e51ba43a519f68c51c57fb0c84958:
| Sandbox | Source |
|---|---|
| react-testing-library-examples | Configuration |
codecov[bot]
commented
1 year ago Merging #1213 (746def6) into main (0ce0c70) will not change coverage. The diff coverage is
100.00%.
@@ Coverage Diff @@
## main #1213 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 998 992 -6
Branches 327 322 -5
=========================================
- Hits 998 992 -6 | Flag | Coverage Ξ | |
|---|---|---|
| node-12 | ? |
|
| node-14 | 100.00% <100.00%> (ΓΈ) |
|
| node-16 | 100.00% <100.00%> (ΓΈ) |
|
| node-18 | 100.00% <100.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Ξ | |
|---|---|---|
| src/helpers.ts | 100.00% <ΓΈ> (ΓΈ) |
|
| src/query-helpers.ts | 100.00% <ΓΈ> (ΓΈ) |
|
| src/screen.ts | 100.00% <ΓΈ> (ΓΈ) |
|
| src/queries/label-text.ts | 100.00% <100.00%> (ΓΈ) |
|
| src/queries/role.ts | 100.00% <100.00%> (ΓΈ) |
:mega: Weβre building smart automated test selection to slash your CI/CD build times. Learn more
eps1lon
commented
1 year ago Small update: It did catch some breaking changes during type-checking. Specifically, we had a bunch of queries using exact: false. It looks like it was assumed exact applies to name not role considering that removing the option did not break runtime tests. If it was intended (e.g. including role="spinbutton") then I'm ok with this breaking change. People should make it explicit what roles they expect instead of relying on perfect knowledge of all possible roles (which is especially problematic since new roles can be added to ARIA).
Will be fast-forward merge on 16.02.2023 unless we need to revise some changes.
Tested latest alpha on the Klarna monorepo and this caught some bad queries assuming
exactapplied to thenameoption. Butexactapplies to therole. This is why these options were removed: they're misleading and most likely not needed.9.0.0-alpha.2 (2023-02-09)
Bug Fixes
BREAKING CHANGES
stringas arole. Drop support forexact,trim,collapseWhitespace, andnormalizeroptions.9.0.0-alpha.1 (2023-01-29)
Features
BREAKING CHANGES