testing-library / dom-testing-library

πŸ™ Simple and complete DOM testing utilities that encourage good testing practices.
https://testing-library.com/dom
MIT License
3.26k stars 466 forks source link

test: add missing test for suggestions #1215

Closed MatanBobi closed 1 year ago

MatanBobi commented 1 year ago

What: Add a test that was missing for throwing suggestions

Why: While working on the docs requested in the discussion between @eps1lon and @timdeschryver, I saw that based on the implementation, there's a missing test.

Checklist:

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 183d075b2aa5ec1cf51263af55c57247e7337cf4:

Sandbox Source
react-testing-library-examples Configuration
codecov[bot] commented 1 year ago

Codecov Report

Merging #1215 (183d075) into main (4da0f39) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1215   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          992       992           
  Branches       322       322           
=========================================
  Hits           992       992           
Flag Coverage Ξ”
node-14 100.00% <ΓΈ> (ΓΈ)
node-16 100.00% <ΓΈ> (ΓΈ)
node-18 100.00% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more