Fix role assignment for imgs with alt attribute

testing-library / dom-testing-library

🐙 Simple and complete DOM testing utilities that encourage good testing practices.

https://testing-library.com/dom

MIT License

3.25k stars 463 forks source link

Fix role assignment for imgs with alt attribute #1236

Closed brtrick closed 8 months ago

brtrick commented 1 year ago

What: This PR fixes a bug in assigning the role to imgs. Fixes #1235

Why:

How:

Checklist:

[ ] Documentation added to the docs site N/A
[x] Tests
[ ] TypeScript definitions updated N/A
[x] Ready to be merged

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4dcc5d14e283fa2f49cc7ac949ad8800f923eb9b:

Sandbox	Source
react-testing-library-examples	Configuration

MatanBobi commented 8 months ago

I'm closing this one because AFAIU it's resolved by #1241. @jlp-craigmorten, @brtrick if I got it wrong, please comment here and I'll re-open :) Thanks for the time working on this one!