search

testing-library / dom-testing-library

🐙 Simple and complete DOM testing utilities that encourage good testing practices.
https://testing-library.com/dom
MIT License
3.25k stars 463 forks source link

chore: add accessibility-alt-text-bot #1240

Closed MatanBobi closed 10 months ago

MatanBobi commented 1 year ago

What: Adds a workflow to add the accessibility alt text bot. Following this guide.

Why: To enforce adding alt text to images in issues and PR's.

Checklist:

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f5699723de07954d25a1d18f793b3bbabdacae48:

Sandbox Source
react-testing-library-examples Configuration
codecov[bot] commented 1 year ago

Codecov Report

Merging #1240 (f569972) into main (069e184) will not change coverage. The diff coverage is n/a.

:exclamation: Current head f569972 differs from pull request most recent head 2c04510. Consider uploading reports for the commit 2c04510 to get more accurate results

@@            Coverage Diff            @@
##              main     #1240   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         1038      1038           
  Branches       346       346           
=========================================
  Hits          1038      1038
Flag Coverage Δ
node-14 100.00% <ø> (ø)
node-16 100.00% <ø> (ø)
node-18 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

MatanBobi commented 12 months ago

I like the idea. But the build seems to be having some troubles with it 👀

Oh, I think it's failing because I'm not synced with master and we pinned browserlist, I'll fix that :) Thanks!

nickmccurdy commented 12 months ago

@MatanBobi Thanks! Feel free to merge this if you want, as this clearly isn't the cause of the CI failure, and merging should fix it anyway.

MatanBobi commented 12 months ago

Ok, the reason it's failing is because we're testing on Node 14 and have an overrides solution for browserlist which doesn't work in npm 6. That's a problem because our tests will always fail for node 14 with this solution. I've written that in the issue we have.

nickmccurdy commented 10 months ago

I think we can just merge this then, I'm not aware of any issues that aren't already on main.