test(role-helpers): improve coverage of logRoles fn

testing-library / dom-testing-library

🐙 Simple and complete DOM testing utilities that encourage good testing practices.

https://testing-library.com/dom

MIT License

3.28k stars 467 forks source link

test(role-helpers): improve coverage of logRoles fn #1248

Open naorpeled opened 1 year ago

naorpeled commented 1 year ago

What:

Increased the tests coverage of the logRoles and prettyRoles functions in the role helpers file, at the moment cases with hidden = true option were not covered.

Why:

To further understand the scope of #1201 I've added these tests, I think it's good to have them in the repo.

Checklist:

[ ] Documentation added to the docs site
[x] Tests
[ ] TypeScript definitions updated
[x] Ready to be merged

naorpeled commented 1 year ago

Thanks for the PR @naorpeled. Because this PR contains 2 changes (types, and additional tests) I think it would be better to also create 2 focused PR. This makes it easier to follow, and we have more control over the releases/history.

Fair point. Will do.

naorpeled commented 1 year ago

@timdeschryver thanks for the great feedback. I'm heading off to sleep, will make the adjustments tomorrow 🙏

naorpeled commented 1 year ago

Hey @timdeschryver, I've updated the PR based on your CR. Also opened this PR for the type defs.

naorpeled commented 1 year ago

LGTM. Sorry, I missed the notification

All good :) Thanks!