fix(role-helpers): refine logRoles fn types

testing-library / dom-testing-library

🐙 Simple and complete DOM testing utilities that encourage good testing practices.

https://testing-library.com/dom

MIT License

3.25k stars 463 forks source link

fix(role-helpers): refine logRoles fn types #1249

Closed naorpeled closed 10 months ago

naorpeled commented 11 months ago

What:

Increased the TS coverage of the logRoles and prettyRoles functions in the role helpers file, at the moment cases with hidden = true option were not covered.

Why:

To further understand the scope of #1201 I've added these defs, I think it's good to have them in the repo.

Checklist:

[ ] Documentation added to the docs site
[ ] Tests
[x] TypeScript definitions updated
[x] Ready to be merged

MatanBobi commented 10 months ago

@all-contributors please add @naorpeled for code :)

allcontributors[bot] commented 10 months ago

@MatanBobi

I've put up a pull request to add @naorpeled! :tada: