testing-library / dom-testing-library

🐙 Simple and complete DOM testing utilities that encourage good testing practices.
https://testing-library.com/dom
MIT License
3.25k stars 463 forks source link

feat: Drop support for Node.js 14.x and Node.js 16.x and add support for Node 20.x #1255

Closed MatanBobi closed 10 months ago

MatanBobi commented 10 months ago

BREAKING CHANGE: Minimum supported Node.js version is now 18.x

What: This PR drops support for Node 14 and Node 16.

Why: Node 14 was declared EOL on May 23, Node 16 will be declared EOL on September 11.

How: Upgrade all relevant places.

Checklist:

~~- [ ] Documentation added to the docs site~~

codesandbox-ci[bot] commented 10 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 86beed61d8068b245613afddd4673231385a2d4e:

Sandbox Source
react-testing-library-examples Configuration
codecov[bot] commented 10 months ago

Codecov Report

Merging #1255 (86beed6) into alpha (365d555) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             alpha     #1255   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         1038      1038           
  Branches       349       349           
=========================================
  Hits          1038      1038           
Flag Coverage Δ
node-16 ?
node-18 100.00% <ø> (ø)
node-20 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

nickmccurdy commented 10 months ago

Feel free to merge if you're ready. I think it would be helpful to base other alpha PRs off this to avoid noise in CI.