Closed eps1lon closed 9 months ago
MatanBobi
commented
10 months ago This was already done as part of https://github.com/testing-library/dom-testing-library/pull/1255 which is merged to alpha, is there any specific reason to have another pr?
eps1lon
commented
10 months ago To have it in main. https://github.com/testing-library/dom-testing-library/pull/1255/ also drops support for Node.js 14 which I don't want to do. We can package that with actual features but I see no reason releasing a Major with just Node.js 14 support dropped. That seems kind of boring.
codesandbox-ci[bot]
commented
10 months ago This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 5d14849627baee2e849c4f51b1b9c6dc8fda901e:
| Sandbox | Source |
|---|---|
| react-testing-library-examples | Configuration |
codecov[bot]
commented
10 months ago Merging #1263 (5d14849) into main (07f5999) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## main #1263 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 1038 1038
Branches 351 351
=========================================
Hits 1038 1038 | Flag | Coverage Ξ | |
|---|---|---|
| node-14 | 100.00% <ΓΈ> (ΓΈ) |
|
| node-16 | 100.00% <ΓΈ> (ΓΈ) |
|
| node-18 | 100.00% <ΓΈ> (ΓΈ) |
|
| node-20 | 100.00% <ΓΈ> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: Weβre building smart automated test selection to slash your CI/CD build times. Learn more
Current Node.js release that will go into LTS next month