search

testing-library / dom-testing-library

🐙 Simple and complete DOM testing utilities that encourage good testing practices.
https://testing-library.com/dom
MIT License
3.25k stars 460 forks source link

Update package.json #1300

Closed rajagopalpalani closed 2 months ago

rajagopalpalani commented 2 months ago

To support latest react version

What:

Why:

How:

Checklist:

codesandbox-ci[bot] commented 2 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2bee54f04bbfe47c92dcfd4205512ad3ecd9d2f9:

Sandbox Source
react-testing-library-examples Configuration
MatanBobi commented 2 months ago

@rajagopalpalani Can you please provide more context into why this change is needed?

lukeapage commented 2 months ago

I just coincidentally came across this because typescript performance analyse pointed this out as a duplicate package in node_modules. Its to upgrade so they can be deduped.

MatanBobi commented 2 months ago

What's the reason it's duplicated? Is that only for your package? I don't see a reason for this to be duplicated in our repo. To solve this on your end, you can use yarn resolutions or npm overrides

lukeapage commented 2 months ago

We depend on testing library and jest and jest is upgraded and testing library is not.

I have no idea if this pr is correct or not but why wouldn’t you want to regularly update to the latest version ?

MatanBobi commented 2 months ago

Since we're following semver, we need to understand if this should cause a major upgrade in our library which we just made. I'm not sure and I currently don't have the time to invest in understanding what are the changes in pretty-format. If we're exporting some of it's functionalities, this might break our API.

rajagopalpalani commented 2 months ago

I thought version was an issue. I am closing this MR. Its an issue from our end