feat(prefer-implicit-assert): adding new rule

testing-library / eslint-plugin-testing-library

ESLint plugin to follow best practices and anticipate common mistakes when writing tests with Testing Library

https://npm.im/eslint-plugin-testing-library

MIT License

968 stars 135 forks source link

Closed adevick closed 8 months ago

adevick commented 9 months ago

Adding a new rule to prefer implicit assertions when using findBy* and getBy* queries

Closes #743

adevick commented 9 months ago

@Belco90 just checking in thanks!

Belco90 commented 9 months ago

I'll try to review this next week.

adevick commented 8 months ago

@Belco90 Hey thanks for the review, fixed all but the last comment.

adevick commented 8 months ago

@Belco90 addresssed test coverage, turns out I didn't need those extra blocks of code after the refactor, and should be all green now. Thanks!

github-actions[bot] commented 8 months ago

:tada: This PR is included in version 6.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Belco90 commented 8 months ago

@all-contributors please add @adevick for code, test, docs

allcontributors[bot] commented 8 months ago

@Belco90

I've put up a pull request to add @adevick! :tada: