Disallow usages of innerHTML for no-container rule

testing-library / eslint-plugin-testing-library

ESLint plugin to follow best practices and anticipate common mistakes when writing tests with Testing Library

https://npm.im/eslint-plugin-testing-library

MIT License

992 stars 142 forks source link

Disallow usages of innerHTML for no-container rule #889

Open CodingItWrong opened 8 months ago

CodingItWrong commented 8 months ago

Checks

[X] I have read the contributing guidelines.

Changes

So far, updates the rule to reject when innerHTML is accessed on a destructured container proprety
QUESTION: one test case is not yet covered: when the return value of a render function is assigned to a render result variable like view, and then it is accessed as view.container.innerHTML. For container methods, this seems to be caught by the code on lines 95-106. But we can't use that code as-is in MemberExpression() because of the error Property 'callee' does not exist on type 'MemberExpression'.. Looking over our code, do you have an ideas on how we could detect the view.container.innerHTML case in MemberExpression()? @Belco90

Context

Fixes #883

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.21%. Comparing base (93a6ab9) to head (514ef11). Report is 4 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #889 +/- ## ========================================== - Coverage 96.23% 96.21% -0.03% ========================================== Files 44 44 Lines 2419 2432 +13 Branches 1000 1007 +7 ========================================== + Hits 2328 2340 +12 - Misses 91 92 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MichaelDeBoey commented 1 month ago

@CodingItWrong Are you still interested in implementing this feature?

If so, can you please rebase onto latest main?

CodingItWrong commented 1 week ago

Hi @MichaelDeBoey, I've moved on from the consultancy where I was working when implementing this functionality, and unfortunately I'm no longer able to continue work on it.