testing-library / eslint-plugin-testing-library

ESLint plugin to follow best practices and anticipate common mistakes when writing tests with Testing Library
https://npm.im/eslint-plugin-testing-library
MIT License
992 stars 142 forks source link

fix: replace use of deprecated methods #925

Closed G-Rath closed 1 month ago

G-Rath commented 3 months ago

Checks

Changes

Context

Resolves #924 Resolves #899

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.31%. Comparing base (93a6ab9) to head (88ecc28). Report is 21 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #925 +/- ## ========================================== + Coverage 96.23% 96.31% +0.07% ========================================== Files 44 45 +1 Lines 2419 2470 +51 Branches 1000 1023 +23 ========================================== + Hits 2328 2379 +51 Misses 91 91 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

G-Rath commented 3 months ago

926 proves that this works with ESLint v7, v8, and v9 so I think this should be safe to merge as-is and then we'll be one step closer to supporting ESLint v9 officially

(the CI failure is just a flakey timeout - it should pass if rerun)

G-Rath commented 2 months ago

@Belco90 @MichaelDeBoey would it be possible to get this and my follow-up PRs progressed, given that they can be released in a minor version?

Belco90 commented 1 month ago

Thanks for your contribution, and sorry for the inactivity. I'll try to get this merged during the week.

G-Rath commented 1 month ago

@Belco90 no worries, let me know if there's anything I can do to help - just in case you've not seen it, I've got a few pull requests open which include ones that ultimately lead to allowing ESLint v9 which are chained off of each other.

In order they are:

I should be able to have them rebased within minutes of you landing the prior ones unless I'm sleep, but I can also do a single big PR if you're prefer.

Let me know what works best for you, and also if you have questions or want something done differently

Belco90 commented 1 month ago

@G-Rath Amazing, thank you so much! I'm going to merge some other chore PRs first (like your editorconfig PR), then we can rebase this one and start reviewing in the order you mentioned.

G-Rath commented 1 month ago

@Belco90 this is good to go now!

Belco90 commented 1 month ago

@G-Rath Ah sorry, this must be reformatted after I merged the prettier v3 upgrade.

G-Rath commented 1 month ago

@Belco90 done 🙂

github-actions[bot] commented 1 month ago

:tada: This PR is included in version 6.3.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: