search

testing-library / jest-dom

:owl: Custom jest matchers to test the state of the DOM
https://testing-library.com/docs/ecosystem-jest-dom
MIT License
4.4k stars 391 forks source link

fix: Support @starting-style #602

Closed jantimon closed 3 months ago

jantimon commented 4 months ago

What:

Upgraded the @adobe/css-tools dependency to include the fix for parsing the @starting-style CSS feature, which was causing a missing '}' error.

Why:

The current version of @adobe/css-tools used by testing-library/jest-dom fails to parse the @starting-style CSS feature, resulting in a parsing error. The upgrade includes a fix for this issue, allowing for the correct parsing of CSS files using @starting-style.

How:

The changes were implemented by updating the package.json file to use the latest version of @adobe/css-tools which includes the fix from the PR I submitted to @adobe/css-tools (https://github.com/adobe/css-tools/pull/323).

Checklist:

Additional Comments:

Unfortunately, I could not add a test case for the @starting-style feature because jsdom 20 uses CSSOM 0.6.0 for CSS parsing, which also has a similar issue. I fixed that already in this PR (https://github.com/rrweb-io/CSSOM/pull/1), but the latest version of jsdom cannot be merged into jest. See https://github.com/jestjs/jest/pull/14846#issuecomment-1885785901 for details

gnapse commented 3 months ago

@all-contributors please add @jantimon for bug

allcontributors[bot] commented 3 months ago

@gnapse

I've put up a pull request to add @jantimon! :tada: