Closed AEgan closed 4 years ago
Merging #97 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #97 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 20 20
Lines 268 268
Branches 67 67
=====================================
Hits 268 268
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a1f9f85...2902f8e. Read the comment docs.
@allcontributors please add @AEgan for code
@bcarroll22
I've put up a pull request to add @AEgan! :tada:
@bcarroll22 when can we expect a new release that includes this PR?
:tada: This PR is included in version 6.0.0 :tada:
The release is available on:
npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:
prevents asyncAct throwing an error if the item being logged isn't a string.
Coped mostly from https://github.com/testing-library/react-testing-library/pull/476
What:
Following a similar PR made in react-testing-library, this fixes an issue where act-compat assumed console.error was being called with a string.
Why:
Current implementation assumes console.error was always called with a string even though it could be called with other types.
How: Wrapped execution of code in a type check if statement to ensure operations are done only on string types.
Checklist: