search

testing-library / react-testing-library

🐐 Simple and complete React DOM testing utilities that encourage good testing practices.
https://testing-library.com/react
MIT License
18.93k stars 1.1k forks source link

use rerender props in wrapper #1284

Open jjoselv opened 6 months ago

jjoselv commented 6 months ago

Describe the feature you'd like:

I would like to be able to test a re-render with a different wrapper. The use case is to ensure that returned callbacks of the tested hook are changed when a new wrapper is used.

Mimic what was added in the testing-library/react-hooks-testing-library in https://github.com/testing-library/react-hooks-testing-library/pull/381

Additionally, update the types of wrapper.

Suggested implementation:

I can't manage to modify pure.js to convey this.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

eps1lon commented 6 months ago

It should be a different option. It's just confusing to pass the same props to both the hook and the wrapper component. Especially from a type perspective this is a nightmare.

The requested API is especially odd since we don't seem to need it for component testing. I'm inclined to recommend to people to write a test component instead and test that with render. renderHook was really just a convenience wrapper for the 90% not a 1st class testing API.