testing-library / svelte-testing-library

:chipmunk: Simple and complete Svelte DOM testing utilities that encourage good testing practices
https://testing-library.com/docs/svelte-testing-library/intro
MIT License
620 stars 33 forks source link

chore: fix linting, formatting, and git hooks configs #291

Closed mcous closed 9 months ago

mcous commented 10 months ago

Overview

This PR fixes some code quality configs and hookups that we making it difficult to contribute effectively to this project.

Part of a two PR change set:

  1. 291 <-- you are here

  2. 292

Change log

(On a personal note, I'm not a huge fan of pre-commit hooks anymore. I find they interfere with people's personal work styles, and they're pretty unnecessary in a PR-squashing-based workflow. I'd be down to ditch the pre-commit stuff from the repo entirely)

yanick commented 9 months ago

On a personal note, I'm not a huge fan of pre-commit hooks anymore.

Ditto. I'll create an issue for potentially ditching husky (and I'll let it simmer a few days to see if anyone comes out of the woodwork to oppose the motion. :-)

mcous commented 9 months ago

@yanick I've noticed PRs landing with merge commits, would you mind if we switched to squash merges? I find they're much easier for contributors (no need to keep an individual PR's history clean) and they tend to be more reliable with automatic versioning tools like semantic-release

If not, let me know and I can squash up the history here myself

yanick commented 9 months ago

would you mind if we switched to squash merges?

In theory I prefer merge commits, but in reality I have to admit that the power of having a branch history is rarely used to have commits of the form "I did this..." "... and then that..." "and finally that" and much more "I did this..." "...and then prettier complained..." "... and I made a typo..." "... does it work now?", so yeah practically it's not that much of a good thing. :-)

So, sure, I'll go and switch the setting to squashing and let's try it.

github-actions[bot] commented 9 months ago

:tada: This PR is included in version 4.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: