Closed mcous closed 7 months ago
Smoke tested by running on my company's ~1000 test suite, everything seemed to behave. Marking this one as ready for review, accordingly!
The changes in this PR have been merged into next
. Gonna close this PR as unnecessary!
Overview
This PR fixes #190 by simplifying the caching strategy and ensuring the
target
div is added to the cache as soon as it's created, rather than after the component is rendered.While working on this PR, I noticed a few inconsistencies with the
render
function's API, so I filed #312 and #313Will keep this as a draft until I've smoke tested on my current app's suite
Change log
target
element to cache immediatelyrenderComponent
functioncleanupComponent
andcleanupTarget
functionscomponent.$$.on_destroy
usage~ I elected to keep this for strict backwards compatibility$$.on_destroy
was added in #54, which was a big rewrite about 5 years agounmount
andcleanup