testing-library / svelte-testing-library

:chipmunk: Simple and complete Svelte DOM testing utilities that encourage good testing practices
https://testing-library.com/docs/svelte-testing-library/intro
MIT License
620 stars 33 forks source link

chore(release): note breaking changes for v5 #347

Closed mcous closed 7 months ago

mcous commented 7 months ago

8d98aa5 landed in next with two issues that I didn't realize when I was writing my commit message:

This means that the breaking changes in #325 were released improperly as v4.2.2 instead of v5.0.0 on the next dist tag. This PR adds an empty commit with the correct BREAKING CHANGE message below to hopefully trigger a major bump. I'm leaving this as a draft in case there are other breaking changes that should be incorporated in the v5 release.

BREAKING CHANGE: render is now more strict about the target option, and the container result is now the direct parent of your component instance.

mcous commented 7 months ago

@yanick looks like we just had another release go out on next, did you see this PR and my notes?

yanick commented 7 months ago

Yup, I am on this very page and was about to say "let's merge this, and get v5 out of the door".

So, uh, let's merge this, and get v5 out of the door. :-)

github-actions[bot] commented 7 months ago

:tada: This PR is included in version 5.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 7 months ago

:tada: This PR is included in version 5.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: