search

testing-library / svelte-testing-library

:chipmunk: Simple and complete Svelte DOM testing utilities that encourage good testing practices
https://testing-library.com/docs/svelte-testing-library/intro
MIT License
620 stars 33 forks source link

chore(release): promote v5 as an main consumption release #352

Closed yanick closed 7 months ago

mcous commented 7 months ago

Uh oh, looks like our accessors test broke in latest Svelte 5! No need to block promotion to main in my mind; we can continue to fix Svelte 5 issues as they come up

From reading the semantic-release docs, we should make sure this PR lands into main as a regular merge commit, not a squash

yanick commented 7 months ago

Uh oh, looks like our accessors test broke in latest Svelte 5! No need to block promotion to main in my mind; we can continue to fix Svelte 5 issues as they come up

I was looking into it, but you have a good point. I'll deploy and create the issue for the follow-up.

From reading the semantic-release docs, we should make sure this PR lands into main as a regular merge commit, not a squash

Makes sense. For the "short" feature branches, you just want the "atomic" deltas (man, those quotes in this sentence are doing some heavy work...), but for the next->main you want a better history. Now, I just have to remember that for the next 10 minutes. :-)

yanick commented 7 months ago

:take a deep breath: Here comes nothing...

github-actions[bot] commented 7 months ago

:tada: This PR is included in version 5.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 7 months ago

:tada: This PR is included in version 5.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: