search

testing-library / svelte-testing-library

:chipmunk: Simple and complete Svelte DOM testing utilities that encourage good testing practices
https://testing-library.com/docs/svelte-testing-library/intro
MIT License
620 stars 33 forks source link

fix(release): trigger release #355

Closed yanick closed 7 months ago

yanick commented 7 months ago

:sigh: A chore doesn't bump up the version. This one should.

github-actions[bot] commented 7 months ago

:tada: This PR is included in version 5.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

mcous commented 7 months ago

🤦

yanick commented 7 months ago

🤦

Eventually, I'll get it right.

.... eventually.

mcous commented 7 months ago

I like semantic-release in theory but at least in my short experience using it in this repo it's been nothing but sharp edges and footguns

yanick commented 7 months ago

I like semantic-release in theory but at least in my short experience using it in this repo it's been nothing but sharp edges and footguns

:cover bandages with a blanket: I have no clue what you're talking about. ;-)

Of course, it doesn't help that we didn't set up the system ourselves, so discover a little bit its quirks as we go along. But yeah, I like my automations to give me a final "are you sure? [y/n]" before pulling the trigger. And I think that overall I prefer a system that creates a CHANGELOG file (like, say, https://github.com/changesets/changesets/tree/main#readme) over systems that rely on git messages (which initially sounds handy and elegant, but as soon as you want to edit something.. urgh)