testing-library / testing-library-docs

docs site for @testing-library/*
https://testing-library.com
MIT License
453 stars 709 forks source link

docs(svelte-testing-library): update API docs for v5 release #1369

Closed mcous closed 6 months ago

mcous commented 8 months ago

This is a documentation companion to testing-library/svelte-testing-library#325. We're introducing a few minor, though technically breaking, changes to the API in the upcoming v5 release (which should be triggered upon merge of the PR above).

This PR updates the API section of the svelte-testing-library docs accordingly, with callouts for users of the current v4.

CC @yanick

netlify[bot] commented 8 months ago

Deploy Preview for testing-library ready!

Name Link
Latest commit 02fc3089141c40ab49fc30fae670e289f19ad013
Latest deploy log https://app.netlify.com/sites/testing-library/deploys/662423399a01d60008920c86
Deploy Preview https://deploy-preview-1369--testing-library.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mcous commented 6 months ago

@timdeschryver (pinging you because you’ve reviewed my previous STL docs PRs) we just released v5 to our latest tag, so these docs are ready to go. I’ve synced up and undrafted the PR accordingly

CC @yanick

mcous commented 6 months ago

Thanks for the careful review!

mcous commented 6 months ago

@timdeschryver Is there anything blocking merge here? We just got an inbound issue due to improper API usage that this doc update details

timdeschryver commented 6 months ago

@timdeschryver Is there anything blocking merge here? We just got an inbound issue due to improper API usage that this doc update details

Oops 😅 it got off my radar. Thanks for the ping!