Open jecfish opened 1 year ago
@nickmccurdy fyi!
Thanks, this looks like it would be handy! Is there any implementation documentation or code sample for it yet?
Hi Nick, it will work once you upgrade the @puppeteer/replay dependency in this project and rebuild. There's no extra implementation needed.
To see how we build it, this is the code: https://github.com/puppeteer/replay/blob/main/src/stringify.ts#L68
Is this a side effect of importing the library or do I need to call stringify
?
@nickmccurdy source maps get added by the stringify function and you already call it https://github.com/testing-library/testing-library-recorder-extension/blob/main/src/RecorderPlugin.ts#L13 so no changes in the code are needed (only need to update to the latest replay version).
Ah, I got confused because I forgot about how the extension gets registered, thanks!
Chrome 110 launches a new "Show code and highlight" feature.
How to test You can test this feature with the latest Chrome Canary
Action required
If your extension doesn't have Puppeteer Replay as dependency, you can implement the [sourcemaps] (https://github.com/puppeteer/replay/blob/main/src/stringify.ts#L68) yourself to make it work.
my gif has pretty low res.![ezgif-4-33a0309279](https://user-images.githubusercontent.com/5917927/213026696-fe12fe0b-1229-49e0-9555-5221160b8f6c.gif)