Closed mediafreakch closed 4 years ago
Merging #134 into master will not change coverage by
%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #134 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 68 68
Branches 14 14
=========================================
Hits 68 68
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update d628f36...16c7860. Read the comment docs.
:tada: This PR is included in version 5.0.3 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
In #123 I introduced a different approach to integrate with Vuetify. Unfortunately
setAttribute
always returns undefined, socontainer
eventually was undefined.In my own project this lead to bespoken
Unable to localte target [data-app]
warnings when rendering certain vuetify components, such asv-menu
orv-dialog
. In this example that went unnoticed, because the example component itself was wrapped withinv-app
.I fixed that and added tests for it.
A sidenote: In my own project, adding the container to the body(
document.body.appendChild(root)
) lead to side-effects when interacting withv-menu
. It seemed like the component was leaking between tests. Even with Jest running as--runInBand
. However it doesn't happen in this repo. So for this, I am lost π. Indeed if I copy paste this test and the tested component over to my project, it fails because it cannot find the openedmenu item
:/