testing-library / vue-testing-library

🦎 Simple and complete Vue.js testing utilities that encourage good testing practices.

http://testing-library.com/vue

MIT License

1.08k stars 109 forks source link

Replace `setProps` with `rerender` Function #173

Closed ITenthusiasm closed 4 years ago

ITenthusiasm commented 4 years ago

Removed setProps function (and tests) to confirm with Testing Library standards.
Added rerender function (and tests) to make the API more familiar to the Testing Library family.

codecov[bot] commented 4 years ago

Codecov Report

Merging #173 (4dc3ef2) into next (9e20198) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              next      #173   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           53        58    +5     
  Branches         9         9           
=========================================
+ Hits            53        58    +5

Impacted Files	Coverage Δ
src/vue-testing-library.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e20198...4dc3ef2. Read the comment docs.

ITenthusiasm commented 4 years ago

@afontcu Done!

ITenthusiasm commented 4 years ago

Noticed that @testing-library/vue was being used as an alias to import from the actual JavaScript file in the repository, so I updated my code to conform to the standard.

However, in the future, I think it would be worth simply pointing to the actual file. Doing so would remove the need for the special Jest configuration. More importantly, it would create less confusion for other contributors. Taking a quick look at RTL and STL, they seem to use the regular file name as well instead of using an alias. I'm not going to address that in this PR though. Just pointing something out so it's not forgotten.

afontcu commented 4 years ago

Noticed that @testing-library/vue was being used as an alias to import from the actual JavaScript file in the repository, so I updated my code to conform to the standard. However, in the future, I think it would be worth simply pointing to the actual file.

I did so to make it simpler for users to just "copy&paste" the examples into their codebase and get them working, but I'm totally open to suggestions :)

ITenthusiasm commented 4 years ago

I did so to make it simpler for users to just "copy&paste" the examples into their codebase and get them working, but I'm totally open to suggestions :)

Ah, I see. That makes sense. I'll think about it a bit more before opening up a PR. Thanks!

ITenthusiasm commented 4 years ago

Hey! I noticed that you added some reactions to my comments that seemed positive. Since the PR hasn't been merged yet and I haven't seen any new comments, I just wanted to double check and make sure whether you wanted me to add any more changes or not.

afontcu commented 4 years ago

Hey! I noticed that you added some reactions to my comments that seemed positive. Since the PR hasn't been merged yet and I haven't seen any new comments, I just wanted to double check and make sure whether you wanted me to add any more changes or not.

Hey! yeah, it looks good :) I'll be probably merging and releasing it soon. Thanks! 🚀

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 6.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: