Closed ITenthusiasm closed 3 years ago
Merging #173 (4dc3ef2) into next (9e20198) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## next #173 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 53 58 +5
Branches 9 9
=========================================
+ Hits 53 58 +5
Impacted Files | Coverage Δ | |
---|---|---|
src/vue-testing-library.js | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9e20198...4dc3ef2. Read the comment docs.
@afontcu Done!
Noticed that @testing-library/vue
was being used as an alias to import from the actual JavaScript file in the repository, so I updated my code to conform to the standard.
However, in the future, I think it would be worth simply pointing to the actual file. Doing so would remove the need for the special Jest configuration. More importantly, it would create less confusion for other contributors. Taking a quick look at RTL and STL, they seem to use the regular file name as well instead of using an alias. I'm not going to address that in this PR though. Just pointing something out so it's not forgotten.
Noticed that @testing-library/vue was being used as an alias to import from the actual JavaScript file in the repository, so I updated my code to conform to the standard. However, in the future, I think it would be worth simply pointing to the actual file.
I did so to make it simpler for users to just "copy&paste" the examples into their codebase and get them working, but I'm totally open to suggestions :)
I did so to make it simpler for users to just "copy&paste" the examples into their codebase and get them working, but I'm totally open to suggestions :)
Ah, I see. That makes sense. I'll think about it a bit more before opening up a PR. Thanks!
Hey! I noticed that you added some reactions to my comments that seemed positive. Since the PR hasn't been merged yet and I haven't seen any new comments, I just wanted to double check and make sure whether you wanted me to add any more changes or not.
Hey! I noticed that you added some reactions to my comments that seemed positive. Since the PR hasn't been merged yet and I haven't seen any new comments, I just wanted to double check and make sure whether you wanted me to add any more changes or not.
Hey! yeah, it looks good :) I'll be probably merging and releasing it soon. Thanks! 🚀
:tada: This PR is included in version 6.1.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
setProps
function (and tests) to confirm with Testing Library standards.rerender
function (and tests) to make the API more familiar to the Testing Library family.