testing-library / vue-testing-library

🦎 Simple and complete Vue.js testing utilities that encourage good testing practices.

http://testing-library.com/vue

MIT License

1.08k stars 110 forks source link

chore(ci): Enable typecheck #189

Closed afontcu closed 3 years ago

afontcu commented 3 years ago

~Build won't pass until we find a fix for this: https://github.com/microsoft/dtslint/issues/297#issuecomment-733195100~

update: as @nickmccurdy suggested, switching to tsd did the trick!

nickserv commented 3 years ago

Alternatively you may be able to use tsd or ts-expect.

afontcu commented 3 years ago

Alternatively you may be able to use tsd or ts-expect.

sure, I'll take a look! Thank you for the suggestion

codecov[bot] commented 3 years ago

Codecov Report

Merging #189 (89c9bd0) into next (6f1ffbc) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              next      #189   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           77        77           
  Branches        27        27           
=========================================
  Hits            77        77

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f1ffbc...89c9bd0. Read the comment docs.

afontcu commented 3 years ago

I'm merging this, if anyone comes up with a fix for dtslint or a better way to express type testing, I'll be more than happy to review the PR 😃

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 6.5.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: