testing-library / vue-testing-library

🦎 Simple and complete Vue.js testing utilities that encourage good testing practices.
http://testing-library.com/vue
MIT License
1.08k stars 110 forks source link

[Vue 3 Support] Incorrect type definitions in latest release #193

Closed heywhy closed 3 years ago

heywhy commented 3 years ago

Describe the bug A clear and concise description of what the bug is.

The included type definition (types/index.d.ts) for Vue 3 support is missing the routes property in the render options, this fails because the tests are written in a .ts file.

To Reproduce

Expected behavior

Screenshots

Screen Shot 2020-12-13 at 11 55 03 PM Screen Shot 2020-12-13 at 11 55 41 PM

Related information:

Additional context

The problem is the current release on npm which doesn't contain an up-to-date declaration file.

afontcu commented 3 years ago

Hi! This commit https://github.com/testing-library/vue-testing-library/commit/05275b91e801e11c3ee294d31ac43ac634021ca2 should've issued a release with proper types, but looks like CI failed due to some caching issue. Let me see if I can get it working now.

afontcu commented 3 years ago

okay, fixed! 6.3.1 should come now with right types for Router :) https://github.com/testing-library/vue-testing-library/releases/tag/v6.3.1

Closing this up, feel free to open up a new issue if something comes up!

Thanks 🚀