testing-library / vue-testing-library

🦎 Simple and complete Vue.js testing utilities that encourage good testing practices.
http://testing-library.com/vue
MIT License
1.09k stars 109 forks source link

Unexpected parameter format for rerender() - v6 (next) #197

Closed ghost closed 3 years ago

ghost commented 3 years ago

Hi, The rerender function's signature on v6 is:

rerender(props: object): Promise<void>

But this is how it works:

rerender({ props: { error: false } })

I think the props key is redundant and misleading here and it needs to be something like:

rerender({ error: false })
afontcu commented 3 years ago

Hey! Yeah, I agree that it looks weird and that rerender({ error: false }) makes more sense.

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 6.3.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: