testing-library / vue-testing-library

🦎 Simple and complete Vue.js testing utilities that encourage good testing practices.
http://testing-library.com/vue
MIT License
1.08k stars 110 forks source link

replaced queryByTestId with getByTestId in the vue-router test #203

Closed SangilYun closed 3 years ago

SangilYun commented 3 years ago

First of all, thank you for all the test examples. It really helped me to set up the test environment on my project.

I found that this test uses queryBy* to query the element with location-display testid

As it's mentioned in this link, using getBy* query might fit better for this test I think.

codecov[bot] commented 3 years ago

Codecov Report

Merging #203 (50f1834) into master (2312e18) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #203   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          100       100           
  Branches        35        34    -1     
=========================================
  Hits           100       100           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2312e18...50f1834. Read the comment docs.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 5.6.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 6.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: