search

testing-library / vue-testing-library

🦎 Simple and complete Vue.js testing utilities that encourage good testing practices.
http://testing-library.com/vue
MIT License
1.07k stars 111 forks source link

Vue-i18n example test does not exist and has a dead link #222

Closed ghost closed 3 years ago

ghost commented 3 years ago

Describe the bug

The project README contains a link to a vue-i18n example test that does not exist.

To Reproduce

Activate the link and observe a 404 resonse.

Expected behavior

There is either a resource or no link.

ghost commented 3 years ago

The same dead example link is also referenced in the documentation of the callback function parameter of the render function: https://testing-library.com/docs/vue-testing-library/api#callback-function

afontcu commented 3 years ago

Hi! You're right, the correct link is https://github.com/testing-library/vue-testing-library/blob/master/src/__tests__/translations-vue-i18n.js

Fancy to open up a PR fixing either the filename or the links?

ghost commented 3 years ago

Sorry, I was busy. However, I just saw that https://testing-library.com/docs/vue-testing-library/api#callback-function links to a file including the translations- prefix. :-(

ghost commented 3 years ago

Right, hat was yesterday. https://github.com/testing-library/testing-library-docs/commit/376a8f2f5166b4a78a22215e7314aa8eb28c40d5

Removing the prefix seemed simpler (2 fixes with one change) and more consistent with other test file names. Gonna update the PR then.

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 5.7.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 6.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: