search

testing-library / vue-testing-library

🦎 Simple and complete Vue.js testing utilities that encourage good testing practices.
http://testing-library.com/vue
MIT License
1.07k stars 111 forks source link

Drop Node 10 support #231

Closed MichaelDeBoey closed 3 years ago

MichaelDeBoey commented 3 years ago

Because it's EOL.

afontcu commented 3 years ago

Even though this is a breaking change, and given the fact that 6.x version range is reserved to support to Vue 3 (see https://github.com/testing-library/vue-testing-library/issues/176), I think we should merge this one as a chore: so no version is issued, or maybe as a fix: so people can get a new version and handle any potential breaking change due to using node 10 (unlikely, I guess).

Thoughts?

MichaelDeBoey commented 3 years ago

I would merge it together with Vue 3 support

afontcu commented 3 years ago

Yeah, why not! I'll go ahead and change the base branch from the PR now

afontcu commented 3 years ago

fixed in https://github.com/testing-library/vue-testing-library/pull/243