search

testing-library / vue-testing-library

🦎 Simple and complete Vue.js testing utilities that encourage good testing practices.
http://testing-library.com/vue
MIT License
1.07k stars 111 forks source link

feat: allow passing instantiated Vue Router #239

Closed blimmer closed 3 years ago

blimmer commented 3 years ago

This PR supersedes #238 and is similar to #232. If routes is an instantiated Vue Router, it will be used instead of creating a new Vue Router. This allows developers to use abstract mode to avoid the issue described in #210.

Fixes #210

See also docs upates here: https://github.com/testing-library/testing-library-docs/pull/875

codecov[bot] commented 3 years ago

Codecov Report

Merging #239 (70313ae) into master (9d63d71) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #239   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           99        99           
  Branches        33        34    +1     
=========================================
  Hits            99        99
Impacted Files Coverage Δ
src/render.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d63d71...70313ae. Read the comment docs.

afontcu commented 3 years ago

Thanks for this! I left a comment regarding the test, but it looks good overall :)

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 5.8.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 6.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: