search

testing-library / vue-testing-library

🦎 Simple and complete Vue.js testing utilities that encourage good testing practices.
http://testing-library.com/vue
MIT License
1.07k stars 111 forks source link

feat: drop Node 10 support #243

Closed nickserv closed 3 years ago

nickserv commented 3 years ago

Only updates engines, as CI has already been updated.

codecov[bot] commented 3 years ago

Codecov Report

Merging #243 (6e781d1) into next (93317d9) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 6e781d1 differs from pull request most recent head 865f930. Consider uploading reports for the commit 865f930 to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##              next      #243   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           77        99   +22     
  Branches        27        34    +7     
=========================================
+ Hits            77        99   +22
Impacted Files Coverage Δ
src/fire-event.js 100.00% <100.00%> (ø)
src/index.js 100.00% <100.00%> (ø)
src/render.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93317d9...865f930. Read the comment docs.

nickserv commented 3 years ago

Can you bump the major version please? Or you can put this in whatever prerelease branch you want to use if there are other breaking changes.

afontcu commented 3 years ago

Can you bump the major version please? Or you can put this in whatever prerelease branch you want to use if there are other breaking changes.

@nickmccurdy given the fact that 6.x branch is reserved for Vue 3, should we merge this one there, or release a minor version for 5.x noticing that we removed support for node 10?

MichaelDeBoey commented 3 years ago

@afontcu The base branch of this PR should be the next branch, so could your please rebase onto that branch?

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 6.5.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: