testing-library / vue-testing-library

🦎 Simple and complete Vue.js testing utilities that encourage good testing practices.

http://testing-library.com/vue

MIT License

1.08k stars 109 forks source link

fix(types): Remove Router and Vuex dependency from types #246

Closed afontcu closed 3 years ago

afontcu commented 3 years ago

Closes https://github.com/testing-library/vue-testing-library/issues/187

I'm not entirely sure this is the best way to fix the issue, but I want to get the ball rolling.

codecov[bot] commented 3 years ago

Codecov Report

Merging #246 (c9382eb) into main (eba2aed) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #246   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           99        99           
  Branches        34        35    +1     
=========================================
  Hits            99        99

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eba2aed...c9382eb. Read the comment docs.

afontcu commented 3 years ago

releasing this one. As stated before, if anyone comes up with a better way of handling Router/Vuex types without actually importing them, I'm all ears :)

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 5.8.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 6.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: