search

testing-library / vue-testing-library

🦎 Simple and complete Vue.js testing utilities that encourage good testing practices.
http://testing-library.com/vue
MIT License
1.07k stars 111 forks source link

Vue 3.2 Extra peerDependencies vue-sfc-compiler required #261

Open hikariNTU opened 2 years ago

hikariNTU commented 2 years ago

Describe the bug: Starting from vue@3.2.13, @vue/compiler-sfc is built-in dependency in Vue. But removing it from dependencies list will cause package manager to warn about unmet dependency.

To Reproduce: Install vue@next, then install testing library vue, sfc-complier is inside the dependency list if using npm 7+

Expected behavior @vue/compiler-sfc might be marked as optional if and only if vue >= 3.2.13, but I am afraid none of the existing package meta can handle this situation.

ahnpnl commented 2 years ago

hi @afontcu, @vue/test-utils has a release 2.0.0 on latest tag now, can we update this repo to use it instead of rc version?

afontcu commented 2 years ago

Hi @ahnpnl! Just released VTL for Vue 3 on latest: https://www.npmjs.com/package/@testing-library/vue/v/6.6.0

ahnpnl commented 2 years ago

Hi @ahnpnl! Just released VTL for Vue 3 on latest: https://www.npmjs.com/package/@testing-library/vue/v/6.6.0

Thanks @afontcu , but I think there is still a mistake with this https://github.com/testing-library/vue-testing-library/blob/main/package.json#L48 it should be ^2.0.0

afontcu commented 2 years ago

I think there is still a mistake with this https://github.com/testing-library/vue-testing-library/blob/main/package.json#L48 it should be ^2.0.0

"^2.0.0-rc.18" should also accept installing 2.0.0: image

that being said, I'll happily take a PR updating the specified version to 2.0.0 😃