testing-library / vue-testing-library

🦎 Simple and complete Vue.js testing utilities that encourage good testing practices.
http://testing-library.com/vue
MIT License
1.08k stars 110 forks source link

`@vue/compiler-sfc` peer dependency warning #272

Closed edumudu closed 8 months ago

edumudu commented 2 years ago

Describe the bug When installing @testing-library/vue in a project with vue@3.2.13+ and no @vue/compiler-sfc a warning of missing @vue/compiler-sfc peer dependencies is shown

To Reproduce Steps to reproduce the behavior:

You can view the warning in the terminal on Codesandbox

Expected behavior

Is expected to not show any warning about peer deps

Related information:

Additional context

As of vue@3.2.13+ the package @vue/compiler-sfc is included in the vue and can be accessed as vue/compiler-sfc. So is not needed anymore to install it separately, but currently, this project set it as a peer dependency and doesn't seem to use it directly

More info in the package README

I'm opening this issue to know if I am missing something, if it's alright I would be happy to open a PR if needed

zhanglolo commented 2 years ago

vue@2.7.0+ also include @vue/compiler-sfc.

davidysoards commented 1 year ago

+1 OP offered to open a PR, that would be nice.

github-actions[bot] commented 8 months ago

:tada: This issue has been resolved in version 8.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: