search

testing-library / vue-testing-library

🦎 Simple and complete Vue.js testing utilities that encourage good testing practices.
http://testing-library.com/vue
MIT License
1.09k stars 109 forks source link

chore: optional compiler-sfc #288

Closed g1eny0ung closed 9 months ago

g1eny0ung commented 1 year ago

Signed-off-by: Yue Yang g1enyy0ung@gmail.com

Close #272.

Refer to the README, after v3.2.13, the @vue/compiler-sfc can be optional because it has already been included in the vue package.

So I mark this peer dependency as optional.

g1eny0ung commented 1 year ago

@afontcu Mind taking a look at this PR when you are free?

edumudu commented 1 year ago

Just linking that this PR fixes #272

g1eny0ung commented 1 year ago

@afontcu I suddenly remembered this PR again. Almost a year has passed and I would appreciate it if you could take the time to review it.

joaopslins commented 9 months ago

Was cleaning some dependencies in my project and got a warning for this unneeded peer dependency. Would be nice to get this merged 🙇 Do we have any blockers?

g1eny0ung commented 9 months ago

Was cleaning some dependencies in my project and got a warning for this unneeded peer dependency. Would be nice to get this merged 🙇 Do we have any blockers?

I think it's just that the author doesn't bother to actively maintain the repository. 😢

github-actions[bot] commented 9 months ago

:tada: This PR is included in version 8.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

g1eny0ung commented 9 months ago

hey! Sorry this went unnoticed (again). Still taking a look at the lib from time to time, but my buffer nowadays is quite full.

Hi @afontcu, thank you for your review! I apologize for my slightly negative comments earlier. 🙇‍♂️ I'm also a maintainer for some repos and I fully understand that we can all get a little busy and thus neglect some contributions.

Thanks for the PR, merging it now. I reckon we should apply the same change in v5 for Vue 2?

For this question, I checked the Vue 2 docs (https://v2.vuejs.org/v2/guide/migration-vue-2-7#Vue-CLI-webpack) and it says:

*Upgrade vue to ^2.7.0. You can also remove vue-template-compiler from the dependencies - it is no longer needed in 2.7.**

Note: if you are using @vue/test-utils, you will need to keep vue-template-compiler in the dependencies because test utils rely on some APIs only exposed in this package.

So, as vue-testing-library relies on @vue/test-utils, I think we don't need to update the v5 branch anymore.

joaopslins commented 9 months ago

That's awesome! Thanks for the quick reply and the speedy version publish 🙇