search

testing-library / webdriverio-testing-library

🕷️ Simple and complete WebdriverIO DOM testing utilities that encourage good testing practices.
17 stars 14 forks source link

chore: upgrade to Jest 27 #23

Closed nickserv closed 3 years ago

nickserv commented 3 years ago

What: Upgrade to Jest 27

Why: Ensuring compatibility with breaking changes in Jest 27

How: Upgrading packages

nickserv commented 3 years ago

Do we want to fix these lint errors or disable the new ones and deal with it later?

olivierwilkinson commented 3 years ago

Hey, sorry for the slow response. I think fixing them would be good, I've been meaning to improve the type safety anyways so this is as good a time as any. I'll disable some and add a note if something proves difficult. :)

nickserv commented 3 years ago

I'm not sure why webdriverio is failing to connect though, any ideas? I ran a build on master (#25) and it succeeded.

olivierwilkinson commented 3 years ago

I'm not sure why webdriverio is failing to connect though, any ideas? I ran a build on master (#25) and it succeeded.

I think what was happening is that the validate script exits because the lint command fails, so all the other processes get a SIGTERM which is what all that complaining by webdriverio is about haha.

I've fixed the eslint errors now and things seem to be working again so I hope it's something like that 😄

olivierwilkinson commented 3 years ago

I'm not familiar with the inner workings of this library or Webdriverio, but this looks good, thanks!

Awesome 😄 thanks for raising this btw, it prompted some positive changes! (And highlighted some areas that could still be improved 🙂)

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 3.0.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: