fix: injecting DTL when amd define exists

testing-library / webdriverio-testing-library

🕷️ Simple and complete WebdriverIO DOM testing utilities that encourage good testing practices.

16 stars 14 forks source link

fix: injecting DTL when amd define exists #35

Closed olivierwilkinson closed 3 years ago

olivierwilkinson commented 3 years ago

closes #34

https://www.ebay.com has a global define function with define.amd as an empty object. This causes the UMD distribution of Dom Testing Library to use the define function to expose it's methods. Since we assume the methods are available on the TestingLibraryDom object this breaks the library.

Modify the UMD distribution so it creates the TestingLibraryDom even when a define function exists.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 3.0.5 :tada:

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: