Compatibility for upcoming `v8`

testing-library / webdriverio-testing-library

🕷️ Simple and complete WebdriverIO DOM testing utilities that encourage good testing practices.

16 stars 14 forks source link

Compatibility for upcoming `v8` #43

Closed christian-bromann closed 2 years ago

christian-bromann commented 2 years ago

fixes #42

olivierwilkinson commented 2 years ago

So the tests are only failing due to the Chrome version on the Ubuntu container being behind the latest Chromedriver version used by the selenium-standalone service. I've verified they pass locally and have fixed the build on main so I'm going to merge this. We use semantic-release so I need to update the commit format when I merge to trigger a release.

Thanks again for raising this. I'm really happy we now support v8, before it's released no less!

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 3.0.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

christian-bromann commented 2 years ago

Thanks for merging so quickly! I am currently working on a component testing service for WebdriverIO and wanted to make sure folks can use this library too.

olivierwilkinson commented 2 years ago

Thanks for merging so quickly!

No problem at all 😄

I am currently working on a component testing service for WebdriverIO and wanted to make sure folks can use this library too.

Oh that's an interesting project! Not having to spin up and navigate a whole app to get to the component in a real environment sounds awsome. Integration testing a complex component with jsdom is difficult or contrived sometimes for sure. Taking existing jsdom integration tests that use @testing-library/dom and translating them to use this library would be pretty easy too (but of course I would say that haha)

christian-bromann commented 2 years ago

Give it a whirl and raise issues if you have any feedback. Some things I have on my list before making an announcement is:

fix support for react (currently the vite server chokes on rendering React components)
support for DOM snapshots in expect-webdriverio
mocking and stubbing functionlity, e.g. allow to pass in an onClose method as parameter and validate if it got called after certain interaction
documentation, component testing guide, blog post

olivierwilkinson commented 2 years ago

Give it a whirl and raise issues if you have any feedback.

Will do! 😁