search

testing-library / webdriverio-testing-library

🕷️ Simple and complete WebdriverIO DOM testing utilities that encourage good testing practices.
17 stars 14 forks source link

Export esm version of the package #5

Closed idanen closed 3 years ago

idanen commented 3 years ago

Currently can't use this library in a type="module" package. Can we provide an export for esm environments to be used like:

import {setupBrowser} from '@testing-library/webdriverio/esm'

?

olivierwilkinson commented 3 years ago

Hi there 😄

I don't see why not! I'll look into it at some point this week 👍

idanen commented 3 years ago

Opened #6 for your review 😄

olivierwilkinson commented 3 years ago

Opened #6 for your review 😄

Hi! We ended up working on it at the same time! My bad, it was definitely harder to get to this than I expected this last week. I've released at @testing-library/webdriverio@2.1.0-prerelease.1 if you want to try it out and make sure it's working for you. If not I'll working with you on your PR to get that passing CI :)

Edit: I actually prefer your PR so I'll review it to get it passing the CI checks so we can go with that one 😄

olivierwilkinson commented 3 years ago

In my rush to figure out how to proceed I forgot to say thank you for taking the initiative and opening a PR. It's very helpful as I can be sure it now works for you! Sorry for the confusion 😅

idanen commented 3 years ago

No problem 😊 thanks for your fast replies and review. Gotta love Open Source 😄

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 2.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: