search

testiumjs / testium-core

Juggling the bits and pieces to run integration tests
BSD 3-Clause "New" or "Revised" License
4 stars 7 forks source link

feat: add config option to merge chromeOptions #42

Closed amkirwan closed 5 years ago

amkirwan commented 5 years ago
dbushong commented 5 years ago

Thanks for this feature. A few observations:

  1. Since chromeOptions has a lot of different things in it, I'd prefer something like mergeArgs to show what it's operating on
  2. To maintain backward-compatibility, it should default to being false, so the 2nd arg to config.get('desiredCapabilities.chromeOptions.mergeArgs') should be false, I believe
dbushong commented 5 years ago

LGTM; thanks!