Closed Salmela closed 8 years ago
I verified that these changes work on actual course.
Great work! However, I have a few thoughts and feature requests on this implementation.
ImmutableList<Exercise>
for new exercises and updates.O(n^n)
implementation, with a lookup table we could make this O(n)
. This might be helpful: https://github.com/testmycode/tmc-core/blob/master/src/main/java/fi/helsinki/cs/tmc/core/domain/ExerciseKey.javaPlease don't merge this pull request yet. I found typo in one of the unit tests.
This pull request can be now merged. I got the problem fixed.
Awoseme. Nice work!
I am still testing these changes so please don't merge it.