testmycode / tmc-core

The common clientside implementation for tmc-clients. Used by the tmc-netbeans and the tmc-cli
3 stars 18 forks source link

Investigate whether Exercise#{isReturnable, setReturnable} are used #114

Closed nygrenh closed 7 years ago

jamo commented 7 years ago

https://github.com/testmycode/tmc-netbeans/blob/core/tmc-plugin/src/fi/helsinki/cs/tmc/actions/AbstractExerciseSensitiveAction.java#L75

nygrenh commented 7 years ago

Strange, somehow ''Find usages' in Netbeans failed to find that.

Rochet2 commented 7 years ago

Actually it seems tmc-core does not use either of them. Jamox's link is to some other repo. And in that repo it seems setReturnable is not used even if isReturnable is used.

So things that use tmc-core use the functions?

jamo commented 7 years ago

the setter is either for gson deserialization or for testing (tho latter could be achieved just fine with mockito)

nygrenh commented 7 years ago

@Rochet2 No, I searched for both of the methods :).