search

testmycode / tmc-core

The common clientside implementation for tmc-clients. Used by the tmc-netbeans and the tmc-cli
3 stars 18 forks source link

Download adaptive exercises. #119

Closed Mavai closed 7 years ago

Redande commented 7 years ago

Got the following checkstyle errors from running mvn checkstyle:check:

[ERROR] src/main/java/fi/helsinki/cs/tmc/spyware/EventSendBuffer.java:[28] (whitespace) EmptyLineSeparator: 'import' should be separated from previous statement.
[ERROR] src/main/java/fi/helsinki/cs/tmc/spyware/EventSendBuffer.java:[28] (imports) CustomImportOrder: Import statement for 'com.google.common.base.Preconditions.checkArgument' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/main/java/fi/helsinki/cs/tmc/core/TmcCore.java:[7] (imports) CustomImportOrder: Wrong lexicographical order for 'fi.helsinki.cs.tmc.core.commands.DownloadAdaptiveExercise' import. Should be before 'fi.helsinki.cs.tmc.core.commands.DownloadOrUpdateExercises'.
[ERROR] src/main/java/fi/helsinki/cs/tmc/core/TmcCore.java:[42] (imports) CustomImportOrder: Import statement for 'fi.helsinki.cs.tmc.core.commands.Command' is in the wrong order. Should be in the 'SPECIAL_IMPORTS' group, expecting group 'STANDARD_JAVA_PACKAGE' on this line.
[ERROR] src/main/java/fi/helsinki/cs/tmc/core/communication/TmcServerCommunicationTaskFactory.java:[3] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - fi.helsinki.cs.tmc.core.commands.*.
[ERROR] src/main/java/fi/helsinki/cs/tmc/core/communication/TmcServerCommunicationTaskFactory.java:[161,64] (whitespace) SeparatorWrap: '.' should be on a new line.
[ERROR] src/main/java/fi/helsinki/cs/tmc/core/communication/TmcServerCommunicationTaskFactory.java:[165,17] (blocks) RightCurly: '}' at column 17 should be on the same line as the next part of a multi-block statement.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/spyware/EventSendBufferTest.java:[46] (whitespace) EmptyLineSeparator: 'import' should be separated from previous statement.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/spyware/EventSendBufferTest.java:[46] (imports) CustomImportOrder: Import statement for 'org.junit.Assert.assertArrayEquals' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/spyware/EventSendBufferTest.java:[47] (imports) CustomImportOrder: Import statement for 'org.junit.Assert.assertEquals' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/spyware/EventSendBufferTest.java:[48] (imports) CustomImportOrder: Import statement for 'org.junit.Assert.assertTrue' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/spyware/EventSendBufferTest.java:[49] (imports) CustomImportOrder: Import statement for 'org.junit.Assert.fail' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/spyware/EventSendBufferTest.java:[50] (imports) CustomImportOrder: Import statement for 'org.mockito.Matchers.any' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/spyware/EventSendBufferTest.java:[51] (imports) CustomImportOrder: Import statement for 'org.mockito.Mockito.verify' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/GetUpdatableExercisesTest.java:[35] (whitespace) EmptyLineSeparator: 'import' should be separated from previous statement.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/GetUpdatableExercisesTest.java:[35] (imports) CustomImportOrder: Import statement for 'com.google.common.truth.Truth.assertThat' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/GetUpdatableExercisesTest.java:[36] (imports) CustomImportOrder: Import statement for 'org.junit.Assert.assertEquals' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/GetUpdatableExercisesTest.java:[37] (imports) CustomImportOrder: Import statement for 'org.junit.Assert.assertNotEquals' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/GetUpdatableExercisesTest.java:[38] (imports) CustomImportOrder: Import statement for 'org.mockito.Matchers.any' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/AuthenticateUserTest.java:[32] (whitespace) EmptyLineSeparator: 'import' should be separated from previous statement.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/AuthenticateUserTest.java:[32] (imports) CustomImportOrder: Import statement for 'org.junit.Assert.assertEquals' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/AuthenticateUserTest.java:[33] (imports) CustomImportOrder: Import statement for 'org.junit.Assert.assertTrue' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/AuthenticateUserTest.java:[34] (imports) CustomImportOrder: Import statement for 'org.mockito.Mockito.verify' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/PasteWithCommentTest.java:[36] (whitespace) EmptyLineSeparator: 'import' should be separated from previous statement.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/PasteWithCommentTest.java:[36] (imports) CustomImportOrder: Import statement for 'org.junit.Assert.assertEquals' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/PasteWithCommentTest.java:[37] (imports) CustomImportOrder: Import statement for 'org.mockito.Matchers.any' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/GetCourseDetailsTest.java:[22] (whitespace) EmptyLineSeparator: 'import' should be separated from previous statement.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/GetCourseDetailsTest.java:[22] (imports) CustomImportOrder: Import statement for 'com.google.common.truth.Truth.assertThat' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/DownloadOrUpdateExercisesTest.java:[41] (whitespace) EmptyLineSeparator: 'import' should be separated from previous statement.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/DownloadOrUpdateExercisesTest.java:[41] (imports) CustomImportOrder: Import statement for 'com.google.common.truth.Truth.assertThat' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/DownloadOrUpdateExercisesTest.java:[42] (imports) CustomImportOrder: Import statement for 'org.junit.Assert.assertFalse' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/DownloadOrUpdateExercisesTest.java:[43] (imports) CustomImportOrder: Import statement for 'org.junit.Assert.assertTrue' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/DownloadOrUpdateExercisesTest.java:[44] (imports) CustomImportOrder: Import statement for 'org.mockito.Matchers.any' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/DownloadOrUpdateExercisesTest.java:[45] (imports) CustomImportOrder: Import statement for 'org.mockito.Mockito.verify' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/GetOrganizationsTest.java:[23] (whitespace) EmptyLineSeparator: 'import' should be separated from previous statement.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/GetOrganizationsTest.java:[23] (imports) CustomImportOrder: Import statement for 'org.mockito.Mockito.verify' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/SendFeedbackTest.java:[33] (whitespace) EmptyLineSeparator: 'import' should be separated from previous statement.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/SendFeedbackTest.java:[33] (imports) CustomImportOrder: Import statement for 'org.junit.Assert.assertFalse' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/SendFeedbackTest.java:[34] (imports) CustomImportOrder: Import statement for 'org.junit.Assert.assertTrue' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/SendFeedbackTest.java:[35] (imports) CustomImportOrder: Import statement for 'org.mockito.Matchers.any' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/SubmitTest.java:[38] (whitespace) EmptyLineSeparator: 'import' should be separated from previous statement.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/SubmitTest.java:[38] (imports) CustomImportOrder: Import statement for 'org.junit.Assert.assertEquals' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/SubmitTest.java:[39] (imports) CustomImportOrder: Import statement for 'org.mockito.Matchers.any' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/ListCoursesTest.java:[25] (whitespace) EmptyLineSeparator: 'import' should be separated from previous statement.
[ERROR] src/test/java/fi/helsinki/cs/tmc/core/commands/ListCoursesTest.java:[25] (imports) CustomImportOrder: Import statement for 'com.google.common.truth.Truth.assertThat' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
ljleppan commented 7 years ago

Consider squashing the commits (or equiv.), messages like "pls work" are fine in temporary branches but I'd rather avoid them in the master branch.