search

testmycode / tmc-core

The common clientside implementation for tmc-clients. Used by the tmc-netbeans and the tmc-cli
3 stars 18 forks source link

Fix for the #68 #76

Closed wakr closed 9 years ago

wakr commented 9 years ago

This fixes about 95% of the bugs that are related to the 8080-port and all 95% of the tests now use random free port (Tested with the command python -m SimpleHTTPServer 8080). The missing 5% are two tests that I have no clue about why those are failing when the port is not 8080.

Check GetCourseTest and SubmitTest for more information.

ljleppan commented 9 years ago

Regarding the two tests that break with dynamic port selection:

Searching for "8080" returns multiple JSON files, such as /src/test/resources/json/courses.json, is it possible that one of these is the problem?

If the problem indeed is the JSON, can we replace all occurences of "8080" with the dynamically chosen port when setting up the tests?

wakr commented 9 years ago

Will replace and I will start looking if the problem is the .json-files' hard-coded ports

EDIT 20150904-1835: Fixed GetCourseTest and started fixing SubmitTest

wakr commented 9 years ago

Everything should be working now

avihavai commented 9 years ago

I wonder why github has no like-button for commits.

ljleppan commented 9 years ago

LGTM

jamo commented 9 years ago

LGTM