search

testmycode / tmc-core

The common clientside implementation for tmc-clients. Used by the tmc-netbeans and the tmc-cli
3 stars 18 forks source link

change all url strings to URI type #79

Closed DarthKipsu closed 9 years ago

DarthKipsu commented 9 years ago

Fixes #77

ljleppan commented 9 years ago

Added some (Mostly small and superficial) comments. Nice work!

For details on import ordering, see https://google.github.io/styleguide/javaguide.html#s3.3.3-import-ordering-and-spacing. Just mentally replace com.google with fi.helsinki :)

ljleppan commented 9 years ago

Two more import order notes, LGTM when those are fixed.

DarthKipsu commented 9 years ago

Could you please merge this or comment if there's still something to review.

ljleppan commented 9 years ago

Sorry for the delay, we only get a notice when there's a new comment, not when you push new commits to the branch.

LGTM.

We'll merge after @jamox has taken a look as well (likely during tomorrow).

jamo commented 9 years ago

LGTM, nice work.