Don't manually attempt on generating urls but use provided ones

testmycode / tmc-core

The common clientside implementation for tmc-clients. Used by the tmc-netbeans and the tmc-cli

3 stars 18 forks source link

Don't manually attempt on generating urls but use provided ones #82

Closed jamo closed 8 years ago

jamo commented 9 years ago

We should get paths/urls from the json and not to generate it ourselfs. (Only the courses.json needs to be defined manually.) For all available courses we have the details url in the courses.json https://github.com/testmycode/tmc-core/blob/master/src/main/java/fi/helsinki/cs/tmc/core/communication/UrlHelper.java#L31

ghost commented 9 years ago

I can fix this, are there other files where paths/urls from courses.json should be used instead?

jamo commented 9 years ago

Not sure, but in general we should never attempt to build urls, but use the one provided in courses.json and other json files linked from there. So that if we would change routing scheme of the server we wouldn't break anything

jamo commented 8 years ago

I feel like this is done as it's mostly rewritten