search

testmycode / tmc-core

The common clientside implementation for tmc-clients. Used by the tmc-netbeans and the tmc-cli
3 stars 18 forks source link

Fix for the issue #71 #93

Closed wakr closed 8 years ago

wakr commented 9 years ago

https://github.com/testmycode/tmc-core/issues/71

Removed all imports to local Validations & ValidationError and also removed them completely. They weren't in use though?

wakr commented 9 years ago

Restoring Validations-class and Validation-error class would mean that this pr does nothing.

"We want to replace fi.helsinki.cs.tmc.core.domain.submission.ValidationError and fi.helsinki.cs.tmc.core.domain.submission.Validations with the classes provided by TMC-Langs-abstraction."

^ where does this apply now if we need to restore original validations-class?

jamo commented 9 years ago

We don't want to restore the Validation classes, but not remove the unused validation fields of SubmissionResult

wakr commented 9 years ago

If Validation classes are removed SubmissionResult-class cannot contain any reference to it. For example private Validations validations; would of course be illegal line because there is no more import for it (locating actually in the same package). Do you mean restoring this and this?

jamo commented 9 years ago

Could we maybe import those from tmc-langs-abstraction?

wakr commented 9 years ago

There already is a import for tmc-langs-abstraction. @jamox see this, this and this.

jamo commented 9 years ago

I feel like the diff is not showing the whole truth..

jamo commented 9 years ago

I just confused the getValidations and getValidationResults - but why we had both in the first place?

jamo commented 9 years ago

Well that field is not in our original code The only thing what I'm wondering is that the json we get from the server has field validations and how gson sets the correct value if the name is different