Closed wakr closed 8 years ago
Restoring Validations-class and Validation-error class would mean that this pr does nothing.
"We want to replace fi.helsinki.cs.tmc.core.domain.submission.ValidationError and fi.helsinki.cs.tmc.core.domain.submission.Validations with the classes provided by TMC-Langs-abstraction."
^ where does this apply now if we need to restore original validations-class?
We don't want to restore the Validation classes, but not remove the unused validation fields of SubmissionResult
Could we maybe import those from tmc-langs-abstraction?
I feel like the diff is not showing the whole truth..
I just confused the getValidations and getValidationResults - but why we had both in the first place?
Well that field is not in our original code The only thing what I'm wondering is that the json we get from the server has field validations and how gson sets the correct value if the name is different
https://github.com/testmycode/tmc-core/issues/71
Removed all imports to local Validations & ValidationError and also removed them completely. They weren't in use though?