search

testmycode / tmc-core

The common clientside implementation for tmc-clients. Used by the tmc-netbeans and the tmc-cli
3 stars 18 forks source link

More json cleanup #95

Closed a544jh closed 8 years ago

a544jh commented 8 years ago

75

jamo commented 8 years ago

Nice work, added a few nitpicks, feel free to skip those for now if you feel like it. LGTM - let me know if you feel like doing the few modifications I proposed of if I should merge this as it is.

ljleppan commented 8 years ago

I just noticed we are storing some test resources in /testResources and some in /src/test/resources. Is there any reason to use /testResources as /src/test/resources is the standard?

jamo commented 8 years ago

I thought we even had issue open for moving all test resources to the standard locatio (/src/test/resources) but apparently it was for a different repo.

Yes, we should move those too. Either in this one or in a separate PR

ljleppan commented 8 years ago

While making changes to the test resources, please also remove /src/test/resources/SubmitResponse.json~, or if it's needed for something, remove ~ from the name.

Could probably add a *~ line to .gitignore while we're at it.

a544jh commented 8 years ago

The test resources are now moved to the proper location

jamo commented 8 years ago

Awesome, merging.