Closed a544jh closed 8 years ago
Nice work, added a few nitpicks, feel free to skip those for now if you feel like it. LGTM - let me know if you feel like doing the few modifications I proposed of if I should merge this as it is.
I just noticed we are storing some test resources in /testResources
and some in /src/test/resources
. Is there any reason to use /testResources
as /src/test/resources
is the standard?
I thought we even had issue open for moving all test resources to the standard locatio (/src/test/resources
) but apparently it was for a different repo.
Yes, we should move those too. Either in this one or in a separate PR
While making changes to the test resources, please also remove /src/test/resources/SubmitResponse.json~
, or if it's needed for something, remove ~
from the name.
Could probably add a *~
line to .gitignore
while we're at it.
The test resources are now moved to the proper location
Awesome, merging.
75