Handle test compilation/execution errors

testmycode / tmc-intellij

*BETA* TestMyCode plugin for IntelliJ IDEA

MIT License

24 stars 13 forks source link

Handle test compilation/execution errors #123

Closed cxcorp closed 7 years ago

cxcorp commented 7 years ago

Closes #113.

The RunResult.Status was not being checked after running the tests, meaning that errors occurring during test compilation or running were silently being ignored. Because of this, a "Tests passed" dialog was shown even if the tests weren't even run. I'm not sure if this is a fix for #101, but this should reveal the reason of the fail to the users in the future.

This PR refactors the ErrorMessageService to some extent and adds a dialog box shown when the test run fails.

cxcorp commented 7 years ago

Also, just a note, Ant or whatever it is seems to be producing a lot of unnecessary output from the empty tasks, e.g.

-pre-init:

-init-private:

-init-user:

-init-project:

-init-macrodef-property:

-do-init:

-post-init:

so ideally maybe these could be cleaned up a little (with a regex [\w-]+:\n+(?=[\w-]+:)). Although I suppose there are no guarantees that the same compiler plugin will always be doing the execution.

nygrenh commented 7 years ago

Thanks!

rlmhermans commented 7 years ago

When will this be released in a new version?